-
Notifications
You must be signed in to change notification settings - Fork 900
V5.0.x bump submodules #12152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V5.0.x bump submodules #12152
Conversation
Looks like we have a failure with the bumped pointers? |
We need to bump openpmix to ec54c21 to get the correct handling of |
My patch is actually on PRRTE |
@rhc54 Thanks for the quick fix! Is this related to openpmix/prrte#1864? Sorry if I missed the test case! Now that we have a fix, do you plan to do another RC? |
Does anyone know why the CI actually failed? I don't see enough log output to know, and I certainly cannot reproduce a problem with running a simple "hello" program.
Sort of - but not really. The fix, at least, was unrelated to the fix for that specific issue.
I'd rather not do an RC for every individual problem/fix as that would become overly burdensome. I'd suggest just bumping to the head of the PMIx v4.2 and PRRTE v3.0 branches to pull in any fixes that relate to issues identified with OMPI's rc. We can then decide if another more formal round or rc's is needed. |
084d7c3
to
f1c35e8
Compare
Tracking prrte v3.0 branch in the latest revision. This will start the CI again. Will see will see. |
Looking at CI failure. |
The test appears flaky. I ran it twice, 1 passed 1 failed
Checked v5.0.x branch. Pretty sure this is introduced with new prrte/pmix. |
Given the exact same behavior in #12156, which does not include a bump in submodule pointers, why would you conclude this? |
No. I commented in the wrong thread. The bump introduced a hang. Git bisect shows it's coming from this commit openpmix/prrte@5c19e5e |
Okay, bump it up again to pickup the fix. |
Signed-off-by: Wenduo Wang <[email protected]>
Signed-off-by: Wenduo Wang <[email protected]>
f1c35e8
to
3ab7a80
Compare
@rhc54 Thank you! I'm also testing it on my machine. |
Local test passed! |
@janjust CI passed after bumping the pointers. |
@wenduwan good to merge? |
Ingest prrte and pmix RC