V5.0.x: configury: add support for LLVM 19 #12514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM 18 supports the ASYNCHRONOUS keyword in an interface, but not in a subroutine (!) so test both in order to avoid a false positive that will lead to compilation failure. Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit 8ef1ef8)
as reported in open-mpi#12506, upcoming LLVM 19 can generate some false positive that will make the mpi Fortran modules unusable. Harden the test by using a module in order to fix that. Thanks Paul Osmialowski for bringing this to our attention. Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit 8c601e1)
Try the !DIR$ IGNORE_TKR directive and the type(*) type in order to support upcoming LLVM 19 flang compiler. Thanks Paul Osmialowski for the report and suggesting the solution. Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit 0bc995f)
|
@ggouaillardet @jsquyres cherry-pick for #12512 |
jsquyres
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.