Skip to content

[5.0.x] Fix the info subscriber mechanism and hidden info keys #12529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024

Conversation

devreal
Copy link
Contributor

@devreal devreal commented May 7, 2024

PR #9246 was overzealous in dropping keys, which broke MPI_[Comm|Win|File]_set_info. Also, @wenduwan noted in #11823 that info keys are not properly propagated to subcommunicators in HAN. The root cause is that keys are not kept if there were no subscribers.

This PR makes the following changes:

  • Make sure info keys are always stored in the info object, independent of whether there are subscribers.
  • If there are no subscribers we mark the keys as internal (previously this was done using a IN prefix to the key, now it's a flag). Internal keys are not handed back to the user in MPI[Comm|Win|File]_get_info.
  • Remove the function for explicitly managing the reference count and removing unreferenced info keys. We still track whether info keys are referenced and keys that are not referenced are treated like internal keys.

Cherry-pick of #12498 to v5.0.x

Signed-off-by: Joseph Schuchart [email protected]
(cherry picked from commit 158e54c)

Signed-off-by: Joseph Schuchart <[email protected]>
(cherry picked from commit 158e54c)
@github-actions github-actions bot added this to the v5.0.4 milestone May 7, 2024
@wenduwan wenduwan merged commit e71b6ee into open-mpi:v5.0.x May 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants