v4.1.x: ompi/coll/cuda: implement reduce_local #12752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 050b1ed: ompi/coll/cuda: implement reduce_local
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
Akshay-Venkatesh
force-pushed
the
topic/reduce-local-impl
branch
from
050b1ed to
656c0c2
Compare
janjust
approved these changes
Aug 14, 2024
jsquyres
changed the title
|
This looks related to #12758, even though the file paths have changed. Should probably resolve the discussion there first before merging here. I took the liberty of converting this to Draft so that it's not accidentally merged. |
Signed-off-by: Akshay Venkatesh <[email protected]>
Akshay-Venkatesh
force-pushed
the
topic/reduce-local-impl
branch
from
656c0c2 to
c8eff46
Compare
janjust
approved these changes
Sep 26, 2024
bosilca
approved these changes
Sep 27, 2024
| ptrdiff_t gap; | ||
| char *rbuf1 = NULL, *sbuf1 = NULL, *rbuf2 = NULL; | ||
| size_t bufsize; | ||
| int rc; |
There was a problem hiding this comment.
Why do you need rc ? Just return OMPI_SUCCESS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce_local implementation is missing which causes failures in IMB. The implementation piggybacks on existing cuda reduce implementation to stage/unstage send/receive buffers.
bot:notacherrypick