Skip to content

Changed the hyperlink in README.md and HACKING.md to correctly reflec… #13080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Changed the hyperlink in README.md and HACKING.md to correctly reflec… #13080

merged 1 commit into from
Feb 5, 2025

Conversation

JTM-UofL
Copy link
Contributor

@JTM-UofL JTM-UofL commented Feb 5, 2025

Changed the hyperlink in README.md and HACKING.md to correctly reflect the sphinx webpage

Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsquyres jsquyres merged commit 59d968e into open-mpi:main Feb 5, 2025
15 checks passed
@jsquyres
Copy link
Member

jsquyres commented Feb 5, 2025

@JTM-UofL Could you make a corresponding PR to the v5.0.x branch?

The changes will be essentially the same, but should cite the v5.0.x documentation URLs, not the main branch documentation URLs.

We usually cherry-pick to the v5.0.x release branch, but I think that since the 2 changes will not be the same as the commits on the main branch, you can't really cherry pick. So the commit message should likely cite something to the effect that this is the analogous change to commit 48883b7 on main, but updates the v5.0.x URLs, not the main branch URLs.

Also, in the body of the PR description to the v5.0.x branch, include "bot:notacherrypick" on a line by itself to tell our CI checker that this is intentionally not a cherry pick, and that that's ok.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants