Skip to content

romio: remove it #13119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025
Merged

romio: remove it #13119

merged 2 commits into from
Mar 6, 2025

Conversation

hppritcha
Copy link
Member

@hppritcha hppritcha commented Mar 3, 2025

The MPICH project no longer supports a self-standing ROMIO library.

The embedded ROMIO does not support MPI 4 embiggening (MPI_Count). The embedded ROMIO cannot be built against modern versions of Intel's OneAPI API (ZE). The Open MPI I/O framework work has preferred the OMPIO component since v4.1.0 release.

So, we remove the ROMIO I/O component and remove ROMIO from the 3rd-party software. Update the MPI I/O documentation to no longer refer to ROMIO.

Various updates to github actions, etc.

edgargabriel
edgargabriel previously approved these changes Mar 3, 2025
Copy link
Member

@edgargabriel edgargabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, but because of the size of the commit, there is a good chance that I did not catch everything.

Just as a side note to the comment, OMPIO became the default component for all file systems starting ompi 4.1.x, not 5.0.x

@hppritcha hppritcha force-pushed the remove_romio branch 2 times, most recently from e52b1e6 to d5fa7b3 Compare March 3, 2025 15:55
edgargabriel
edgargabriel previously approved these changes Mar 3, 2025
@hppritcha hppritcha mentioned this pull request Mar 3, 2025
@jsquyres
Copy link
Member

jsquyres commented Mar 4, 2025

Is it possible to add an MCA synonym for romio to be ompio? I.e., if someone runs mpirun --mca io romio, it would automatically substitute in ompio so that an IO module would be loaded and the job would still run?

I don't know if we do MCA param synonyms early enough for this to work, though.

@edgargabriel
Copy link
Member

@jsquyres I am not sure I like this idea, this would make managing end-user expectations difficult, as well as potentially complicate bug reports. I would prefer that their script just fails and they have to make a one-time adjustment to the script. This is a different situation than vader/sm.

In addition, I am also not sure whether it could have legal ramifications.

@edgargabriel
Copy link
Member

we removed for example btl/openib and osc/pt2pt from 4.1 to 5.0, and we just expected that users adjust their scripts. I don't think this is thaaat different.

@jsquyres
Copy link
Member

jsquyres commented Mar 4, 2025

@edgargabriel Ok, fair points.

@ggouaillardet
Copy link
Contributor

FWIW, the current MCA param would be --mca romio314 or whatever ROMIO version we are using.

So I think end users are either used to adjusting their scripts, or they use --mca ^ompio (and I guess that would fail even with a synomym)

@hppritcha
Copy link
Member Author

okay so are we ready to merge this?

@jsquyres
Copy link
Member

jsquyres commented Mar 6, 2025

In general, I think it's ready to go.

I should have thought of this before, though -- this one is important enough that we should put it in the release notes.

The MPICH project no longer supports a self-standing ROMIO library.

The embedded ROMIO does not support MPI 4 embiggening (MPI_Count).
The embedded ROMIO cannot be built against modern versions of Intel's OneAPI API (ZE).
The Open MPI I/O framework work has preferred the OMPIO component since v5.0.0 release.

So, we remove the ROMIO I/O component and remove ROMIO from the 3rd-party software.
Update the MPI I/O documentation to no longer refer to ROMIO.

Add blurb to v6.0.x release notes.

Various updates to github actions, etc.

Signed-off-by: Howard Pritchard <[email protected]>
@hppritcha
Copy link
Member Author

done added a blurb to the release notes for v6.0.x.
@jsquyres please check now.

how did this get removed?

Signed-off-by: Howard Pritchard <[email protected]>
@hppritcha hppritcha merged commit 8a64826 into open-mpi:main Mar 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants