-
Notifications
You must be signed in to change notification settings - Fork 900
A series of minor updates / cleanups #13146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8d972bd
to
b70aa29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I don't see any interest in touching other people code just to remove a trailing empty line. Is there any technical reason for this?
No, there's no technical reason for the 2 style-related commits. I had the hood up (so to speak) while working on another PR, and I accidentally ran a tool of mine that "fixed" all the whitespace problems. So I figured I'd include those changes here to see if there was any interest in including them. They're trivial, but I do agree that they are style changes. The first 3 commits on this PR do have technical justifications, though. |
I have no concerns about the technical commits, just the change of style. Too invasive for no apparent benefit. |
I checked with Ralph (who initially committed this); this is safe to remove. Signed-off-by: Jeff Squyres <[email protected]>
Signed-off-by: Jeff Squyres <[email protected]>
No code or logic changes. Signed-off-by: Jeff Squyres <[email protected]>
No code or logic changes. Signed-off-by: Jeff Squyres <[email protected]>
b70aa29
to
dc7d3cc
Compare
Ok, I removed the last 2 (style-related) commits. If you're cool with this, please approve the PR. Thanks! |
Several commits for trivial cleanups (reviewers are strongly encouraged to look at commits individually rather than the entire PR diff):
The last 2 commits are possibly the only controversial ones. They're arguably cleanups, but related to style. They do make trivial whitespace changes to several lines in the middle of files.