coll/libnbc: fix MPI_I{reduce,allreduce,reduce_scatter,reduce_scatter_block} #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allred_sched_diss was broken : - use ompi_op_reduce() for Fortran/C++ support - use ompi_op_reduce() keeping in mind op might not be commutative - fix buffer overwrite caused by incorrect usage of ompi_3buff_op_user() Thanks Yuki Matsumoto for the report
… commutative op allred_sched_ring algo simply does not work with non commutative op. Thanks Yuki Matsumoto for the report
red_sched_binomial was broken : - use ompi_op_reduce() for Fortran/C++ support - use ompi_op_reduce() keeping in mind op might not be commutative - fix buffer overwrite caused by incorrect usage of ompi_3buff_op_user() - if op is not commutative, reduce on rank 0 and then send the result to root
…n commutative op red_sched_chain algo simply does not work with non commutative op.
reduce_scatter was broken : - use ompi_op_reduce() for Fortran/C++ support - use ompi_op_reduce() keeping in mind op might not be commutative - fix buffer overwrite caused by incorrect usage of ompi_3buff_op_user()
reduce_scatter_block was broken : - use ompi_op_reduce() for Fortran/C++ support - use ompi_op_reduce() keeping in mind op might not be commutative - fix buffer overwrite caused by incorrect usage of ompi_3buff_op_user()
ggouaillardet
changed the title
|
bot:retest |
1 similar comment
|
bot:retest |
fix MPI_IN_PLACE and temporary buffer allocation/usage Thanks Yuki Matsumoto for the report
ggouaillardet
force-pushed
the
topic/libnbc_iallreduce
branch
from
7c9bd29 to
cd8d696
Compare
Offset temporary buffer when a non zero lower bound datatype is used. Thanks Hristo Iliev for the report
Thanks Yuki Matsumoto for the report
|
Test FAILed. |
|
This PR is replaced with #1852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1754