Skip to content

v2.x: updated API oshmem examples to OSHMEM 1.3 #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2016

Conversation

karasevb
Copy link
Member

@karasevb karasevb commented Oct 18, 2016

cherry picked from commit e894a89

@karasevb karasevb force-pushed the v2.x_fix_oshmem_examples branch 2 times, most recently from 63e2b86 to 7e7b5d7 Compare October 18, 2016 19:07
@hppritcha
Copy link
Member

This PR needs a reviewer

@jsquyres
Copy link
Member

I do not see a corresponding commit on master.

All PRs to release branches must contain commits that exist on / are cherry-picked+ported from master.

Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message to include the commit hash of the corresponding commit on master. Thanks.

@jsquyres
Copy link
Member

@karasevb If you could update the commit message to include the cherry-pick notice, that would be great. Thanks.

Git pro tip: If you git cherry-pick -x ... (i.e., use the -x option), it pre-seeds your commit message with a last line that looks like this:

(cherry picked from commit e894a89)

To fix the commit on this PR, you can just git commit --amend and manually put that line at the bottom of the message, and then git push --force to your branch (fixing up a PR like this is just about the only valid reason to force push). If you do that, the new commit+message will show up here on the PR.

@karasevb karasevb force-pushed the v2.x_fix_oshmem_examples branch from 7e7b5d7 to 47b6c8a Compare October 22, 2016 14:34
@karasevb
Copy link
Member Author

@jsquyres Please check.
Thank you for the tip!

@jsquyres
Copy link
Member

@karasevb Perfect; thanks.

@hppritcha When CI finishes, this PR is good to go.

@hppritcha hppritcha merged commit a05db3f into open-mpi:v2.x Oct 24, 2016
@karasevb karasevb deleted the v2.x_fix_oshmem_examples branch January 10, 2017 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants