ompi/comm: make communicator.h safe for C++ bindings #2317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-mpi#2055 Signed-off-by: Nathan Hjelm <[email protected]>
|
@hjelmn Ready to merge? |
|
Hoping to hear whether this fixed the issue. Otherwise it is ready. |
|
bot:ibm:retest |
|
This commit does not quite fix the problem. I think there is more to do in maybe the CC cxx_glue.lo
In file included from ../../../opal/class/opal_object.h:128:0,
from ../../../ompi/errhandler/errhandler.h:36,
from cxx_glue.h:18,
from datatype.cc:18:
../../../opal/threads/thread_usage.h: In function ‘int32_t opal_thread_swap_32(volatile int32_t*, int32_t)’:
../../../opal/threads/thread_usage.h:134:76: error: ‘opal_atomic_swap_32’ was not declared in this scope
return opal_atomic_swap_ ## suffix ((volatile type *) ptr, newvalue); \
^
../../../opal/threads/thread_usage.h:147:1: note: in expansion of macro ‘OPAL_THREAD_DEFINE_ATOMIC_SWAP’
OPAL_THREAD_DEFINE_ATOMIC_SWAP(int32_t, int32_t, 32)
^
In file included from ../../../opal/class/opal_object.h:128:0,
from ../../../ompi/errhandler/errhandler.h:36,
from cxx_glue.h:18,
from comm.cc:27:
../../../opal/threads/thread_usage.h: In function ‘int32_t opal_thread_swap_32(volatile int32_t*, int32_t)’:
../../../opal/threads/thread_usage.h:134:76: error: ‘opal_atomic_swap_32’ was not declared in this scope
return opal_atomic_swap_ ## suffix ((volatile type *) ptr, newvalue); \
^
../../../opal/threads/thread_usage.h:147:1: note: in expansion of macro ‘OPAL_THREAD_DEFINE_ATOMIC_SWAP’
OPAL_THREAD_DEFINE_ATOMIC_SWAP(int32_t, int32_t, 32) |
|
I don't think this is necessary. The correct fix is in #3589. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2055
Signed-off-by: Nathan Hjelm [email protected]