mpi/neighbor_allgatherv: fix copy&paste error and add helpers #2334
Conversation
| @@ -194,6 +194,9 @@ OMPI_DECLSPEC int | |||
| mca_topo_base_dist_graph_neighbors_count(ompi_communicator_t *comm, | |||
| int *inneighbors, int *outneighbors, int *weighted); | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
we already have a ompi_comm_neighbors_count subroutine that does the same think (at least at first glance)
that being said, your new subroutine only uses internal subroutine (vs MPI_*) so i like it better.
should we only keep your subroutine ?
There was a problem hiding this comment.
ompi_comm_neighbors_count using MPI_* interfaces interfere with MPI profiling. I'm in favor of the new routine. Moreover, the new routine should be used everywhere and the former should be removed.
|
@hjelmn Please also fix the check if (in_size > 0 && NULL == displs) {
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_BUFFER, FUNC_NAME);
} |
|
@hjelmn Looks like this PR still needs some work. |
|
The IBM CI (PGI Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/752b78b8734de54ad555409612822542 |
|
@hjelmn please take a look at this. |
|
Ok, should be better now. @ggouaillardet Please take a look. |
|
bot:ompi:retest |
|
bot:ompi:retest |
|
:bot:retest: |
|
bot:ibm:pgi:retest |
This commit adds a helper function to get the inbound and outbound neighbor count and updates the neighbor_allgatherv bindings to use the correct count when checking the input parameters. Fixes open-mpi#2324 Signed-off-by: Nathan Hjelm <[email protected]>
This commit adds a helper function to get the inbound and outbound
neighbor count and updates the neighbor_allgatherv bindings to use the
correct count when checking the input parameters.
Fixes #2324
Signed-off-by: Nathan Hjelm [email protected]