Topic/osc pt2pt 1 thread fixes #2590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If the user uses PSCW synchronization after a Fence then the previous epoch is not reset which can cause the PSCW to transfer data before it is ready leading to wrong answers. * This commit resets the `eager_send_active` in the start call. Signed-off-by: Joshua Hursey <[email protected]>
* When using `MPI_Lock`/`MPI_Unlock` with `MPI_Get` and non-contiguous datatypes is is possible that the unlock finishes too early before the data is actually present in the recv buffer. * We need to wait for the irecv to complete before unlocking the target. This commit waits for the outgoing fragment counts to become equal before unlocking. Signed-off-by: Joshua Hursey <[email protected]>
* When using `MPI_Put` with `MPI_Win_lock_all` a hang is possible since the `put` is waiting on `eager_send_active` to become `true` but that variable might not be reset in the case of `MPI_Win_lock_all` depending on other incoming events (e.g., `post` or ACKs of lock requests. Signed-off-by: Joshua Hursey <[email protected]>
|
@hjelmn Thanks! We have one more patch regarding lock ordering that might need some discussion. I'm preparing that now. We will bring that in as a separate PR since it might require some discussion (might turn into a MPI standard interpretation issue). |
This was referenced Dec 16, 2016
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #2505 for the single threaded case.
@hjelmn I would appreciate a review of these three commits before they go into
master.The multithreaded test case against the
osc/pt2ptcomponent is still failing with wrong answers, hangs, and segvs. We'll open another ticket for that.Note that this commit should go into the
v2.xandv2.0.xbranches. If included in thev2.0.2release we should also put in a protection against usingosc/pt2ptwithMPI_THREAD_MULTIPLEas that currently can lead to wrong answers. We'll need a separate,v2.0.xtemporary commit for that. I can work on generating that change.