master: amd64: save/restore all 64 bits of rbx around cpuid #2679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in the timer check. When -fPIC is used we need to save/restore ebx. The code copied from patcher was meant for 32-bit systems and did not work correctly on 64-bit systems. This commit updates the save/restore to use rbx instead of ebx. Fixes open-mpi#2678 Signed-off-by: Nathan Hjelm <[email protected]>
hjelmn
changed the title
|
@hjelmn please open PR on 2.0.2 and assign to me. |
|
@hppritcha Will do. Will also open vs 1.10.x and 2.x |
|
@hppritcha Wonder if CI should test optimized builds as well. Might have caught this sooner. Not even sure why the CTS-1 build worked. |
|
@hppritcha LANL CI looks like it is offline. |
|
:bot:lanl:retest |
|
@hjelmn I'll modify one of the UH projects to use -O3. It would have caught this. |
jsquyres
changed the title
jsquyres
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in the timer check. When -fPIC is used we need
to save/restore ebx. The code copied from patcher was meant for 32-bit
systems and did not work correctly on 64-bit systems. This commit
updates the save/restore to use rbx instead of ebx.
Fixes #2678
Signed-off-by: Nathan Hjelm [email protected]