Jjhursey topic/timer gettimeofday #3201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable is only used in one file, so make it static. Signed-off-by: Jeff Squyres <[email protected]>
Several component-specific functions were named with a prefix of "opal_timer_base", which was quite confusing. Rename them to have a prefix "opal_timer_linux" to make it clear that they are here in this component (and different than *actual* opal_timer_base symbols). Signed-off-by: Jeff Squyres <[email protected]>
* See open-mpi#3003 for a discussion about this patch. Once we get a better version in place we can revert this change. Signed-off-by: Joshua Hursey <[email protected]>
jsquyres
requested changes
Mar 18, 2017
ompi/mpi/c/wtick.c
Outdated
| @@ -40,6 +41,12 @@ double MPI_Wtick(void) | |||
| { | |||
| OPAL_CR_NOOP_PROGRESS(); | |||
|
|
|||
| /* | |||
| * See https://github.com/open-mpi/ompi/issues/3003 | |||
| * For now we are forcing the use of gettimeofday() until we find a | |||
There was a problem hiding this comment.
This comment is no longer correct.
ompi/mpi/c/wtick.c
Outdated
| #endif | ||
| #else | ||
| #if defined(__linux__) && OPAL_HAVE_CLOCK_GETTIME | ||
| /* QAD no call clock_getres */ |
There was a problem hiding this comment.
What's "QAD" -- why not call clock_getres?
ompi/mpi/c/wtime.c
Outdated
| #if defined(__linux__) && OPAL_HAVE_CLOCK_GETTIME | ||
| struct timespec tp = {.tv_sec = 0, .tv_nsec = 0}; | ||
| (void) clock_gettime(CLOCK_MONOTONIC, &tp); | ||
| return (tp.tv_sec + tp.tv_nsec/1.0e+9); |
There was a problem hiding this comment.
This return is not quite right -- all paths through the original code assign wtime and fall through to call OPAL_CR_NOOP_PROGRESS.
I know the checkpoint/restart code has fallen into disrepair, but the disparity of treatment here is a little odd.
hppritcha
force-pushed
the
jjhursey-topic/timer-gettimeofday
branch
from
2d8482c to
c564ab5
Compare
hppritcha
force-pushed
the
jjhursey-topic/timer-gettimeofday
branch
from
c564ab5 to
12bd4e9
Compare
better solution needed later workaround for open-mpi#3003 Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
jjhursey-topic/timer-gettimeofday
branch
from
12bd4e9 to
b933152
Compare
jsquyres
approved these changes
Mar 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add some PR feedback to @jjhursey 's original PR #3184
@jsquyres this is it. have commitment this evening so its this or wait till tomorrow.