v2.0.x: Add volatile to the pointer in the list_item structure. #3493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change has the side effect of improving the performance of all atomic data structures (in addition to making the code crrect under a certain interpretation of the volatile usage). This commit fixes open-mpi#3450. Signed-off-by: George Bosilca <[email protected]>(cherry picked from commit d7ebcca) Signed-off-by: Jeff Squyres <[email protected]>
hppritcha
approved these changes
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has the side effect of improving the performance of all atomic data structures (in addition to making the code correct under a certain interpretation of the volatile usage).
Original issue: #3450
Master PR: #3468
Fixes #3476 (v2.0.x tracking issue)
Has been approved by @hjelmn @bwbarrett @bosilca on master.
Signed-off-by: George Bosilca [email protected]
(cherry picked from commit d7ebcca)
Signed-off-by: Jeff Squyres [email protected]