Skip to content

v2.0.x: mpi/cxx: remove nonexistent function from cxx glue #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2017

Conversation

hjelmn
Copy link
Member

@hjelmn hjelmn commented May 26, 2017

This commit removes a nonexistent function that was causing build
problems under certain environments.

Reference #3442

Signed-off-by: Nathan Hjelm [email protected]
(cherry picked from commit ee9093c)
Signed-off-by: Nathan Hjelm [email protected]

@hjelmn hjelmn added the bug label May 26, 2017
@hjelmn hjelmn added this to the v2.0.3 milestone May 26, 2017
@hjelmn hjelmn requested a review from jsquyres May 26, 2017 18:51
@jsquyres
Copy link
Member

@hppritcha I don't know if this is too late for v2.0.3 or not; it's pretty small and self-contained. Risk is low.

@jsquyres jsquyres changed the title mpi/cxx: remove nonexistent function from cxx glue v2.0.x: mpi/cxx: remove nonexistent function from cxx glue May 26, 2017
@hppritcha hppritcha modified the milestones: v2.0.4, v2.0.3 May 28, 2017
@hppritcha
Copy link
Member

bot:ompi:retest

@bwbarrett
Copy link
Member

bot:ompi:retest

It looks like this got caught in a misconfiguration of the PR builder that accidentally sucked in the Automake version change.

@bwbarrett
Copy link
Member

bot:ompi:retest

1 similar comment
@hppritcha
Copy link
Member

bot:ompi:retest

@jsquyres
Copy link
Member

Yo @bwbarrett even with the retest from earlier today, https://jenkins.open-mpi.org/jenkins/job/open-mpi.build.platforms/639/Platform=freebsd_11.0/console failed with what looks like the strings.h failure. 😦 Any idea what happened there?

@bwbarrett
Copy link
Member

@jsquyres Ah, right, I think Jenkins / Github builds the branch, not the patches applied on top of v3.x or whatever. So it'll fail until Nathan rebases.

@jsquyres
Copy link
Member

Got it.

@hjelmn Can you rebase this PR? Once you do that, it'll include the <strings.h> fix, and then CI should pass.

Thanks!

This commit removes a nonexistent function that was causing build
problems under certain environments.

Reference open-mpi#3442

Signed-off-by: Nathan Hjelm <[email protected]>
(cherry picked from commit ee9093c)
Signed-off-by: Nathan Hjelm <[email protected]>
@hjelmn hjelmn force-pushed the v2.0.x_cxx_glue branch from cda251e to 2af90f6 Compare June 20, 2017 15:35
@jsquyres
Copy link
Member

Mellanox CI fail is the infrastructure fail (i.e., failed to set status "SUCCESS"). Merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants