predefined MPI object padding: set to fixed number of bytes #3634
Conversation
Convert the predefined MPI object padding to a fixed number of bytes (vs. a multiple of sizeof(void*)) so that the padding is the same size between 32 and 64 bit builds. I.e., we won't have a situation where we've run out of padding in 32 bit builds but still have more space available in 64 bit builds. Fixes open-mpi#3610 Signed-off-by: Jeff Squyres <[email protected]>
|
@bosilca I'm not 100% convinced that this is the correct solution. Yes, it gives us a fixed padding that is the same between 32 and 64 bit builds... but is that important? I.e., is the real fix to #3610 just to increment communicator padding by N multiples of Thoughts? |
|
I prefer this solution to having different paddings on 32 and 64 bits architectures to cover all the needs. If someone that cares about 32 bits proposes a better approach, we take it. Meanwhile, this is good enough. |
This patch fixes a missed case by 5b670a2 (PR #3634). Signed-off-by: George Bosilca <[email protected]>
|
@bwbarrett @hppritcha Turns out that we don't need this PR (and 037a85a) in v3.0.0 because we haven't run out of (32-bit) padding yet in v3.0.0. |
Convert the predefined MPI object padding to a fixed number of bytes (vs. a multiple of sizeof(void*)) so that the padding is the same size between 32 and 64 bit builds. I.e., we won't have a situation where we've run out of padding in 32 bit builds but still have more space available in 64 bit builds.
Fixes #3610
Signed-off-by: Jeff Squyres [email protected]
@bwbarrett @hppritcha This is an ABI-changing commit (albeit pretty low risk). If we want this for v3.0.x, it needs to be in for v3.0.0.