ROMIO 3.1.4 : Add support for missing ops #3688
Conversation
* Protects us from segv when ROMIO 314 is selected and one of the following operations is called: - MPI_File_iread_at_all - MPI_File_iwrite_at_all - MPI_File_iread_all - MPI_File_iwrite_all Signed-off-by: Joshua Hursey <[email protected]>
|
@jjhursey looks generally good, but I have a comment/suggestion: for the explicit offset operations, I would suggest to just simply call the corresponding non-collective version of that operation, e.g. for MPI_File_iread_at_all just call MPI_File_iread_at, and let that operation handle internally how they deal with explicit offsets. Basically, the pattern that you copied was how OMPIO deals with them, but I am not convinced that this is the ROMIO way. MPI_File_iread_at will however do the right thing on your behalf. (t |
|
@edgargabriel Thanks for the suggestion. That sounds like a better path. I'll update the PR in a moment with those modifications. |
* Add work around support for the following missing ops in ROMIO 3.1.4
- `MPI_File_iread_at_all`
- `MPI_File_iwrite_at_all`
- `MPI_File_iread_all`
- `MPI_File_iwrite_all`
Signed-off-by: Joshua Hursey <[email protected]>
jjhursey
force-pushed
the
fix/romio-314-missing-ops
branch
from
29e9564 to
80a91dc
Compare
|
@edgargabriel I just pushed the change to the second commit. Let me know what you think. Thanks! |
|
@jjhursey Don't forget to PR this to the release branches 😄 |
MPI_File_iread_at_allMPI_File_iwrite_at_allMPI_File_iread_allMPI_File_iwrite_allThis mimics the fallback mechanism in OMPIO when it doesn't have internal support.