Detect that we have a mix of BE/LE in the system, provide a warning that OMPI doesn't currently support this environment, and error out #3828
Conversation
…hat OMPI doesn't currently support this environment, and error out Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit 2753f53)
|
@ggouaillardet Are you sure that is true?? I looked but that PR you had created a long time ago was never committed, and so far as I can tell, we still don't work correctly in that mode. |
|
i will resume working on that PR. |
|
I'll leave this PR as-is until we see your PR completed. I'm a little disturbed about changing master without clear evidence that hetero is working again, but let's leave that in for now with the proviso that you get that PR completed and committed soon. |
|
hmm... well I now see something I'd like addressed if we're disabling BE/LE mixed support. Namely, we should at least for a while, remove the --enable-heterogeneous configure option if we know it doesn't work. |
|
Okay - easy enough to add. Will leave master alone, though, pending the PR from @ggouaillardet |
|
the PR is #2940 |
|
@hppritcha I pushed the requested change |
|
I'm not sure I like this patch... Let's push to master and then to v3.0.x. Yes, Giles is working on fixing heterogenous in master, but he can add a revert with the rest of his patch series. We need to get in the habit of not special casing all the branches. |
|
no problem - will do |
Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit 8e25733)
|
Okay, I replaced the custom commit with the one to master: 8e25733 |
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit 2753f53)