Skip to content

opal: Get x86 TSC frequency from bogomips #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2017
Merged

opal: Get x86 TSC frequency from bogomips #3869

merged 1 commit into from
Aug 1, 2017

Conversation

zzzoom
Copy link
Contributor

@zzzoom zzzoom commented Jul 12, 2017

Easiest approach to #3847: Return bogomips * 500000 in opal_timer_linux_find_freq on x86 when opal_sys_timer_is_monotonic, i.e. when rdtsc is in use.

Signed-off-by: Carlos Bederián [email protected]

Signed-off-by: Carlos Bederián <[email protected]>
@ompiteam-bot
Copy link

Can one of the admins verify this patch?

@open-mpi open-mpi deleted a comment from ibm-ompi Jul 12, 2017
@open-mpi open-mpi deleted a comment from ibm-ompi Jul 12, 2017
@open-mpi open-mpi deleted a comment from ibm-ompi Jul 12, 2017
@open-mpi open-mpi deleted a comment from ibm-ompi Jul 12, 2017
@open-mpi open-mpi deleted a comment from ibm-ompi Jul 12, 2017
@open-mpi open-mpi deleted a comment from ibm-ompi Jul 12, 2017
@jjhursey
Copy link
Member

test this please

@zzzoom zzzoom changed the title Get x86 TSC frequency from bogomips opal: Get x86 TSC frequency from bogomips Jul 13, 2017
@bwbarrett
Copy link
Member

@zzzoom, are you going to merge this?

@zzzoom
Copy link
Contributor Author

zzzoom commented Aug 1, 2017

I hope it gets merged. It's low priority though, I don't know if I should tag maintainers for a review or just wait for someone to pick it up.

@jsquyres
Copy link
Member

jsquyres commented Aug 1, 2017

@bwbarrett Zzzoom is not one of the core maintainers; he can't merge.

Copy link
Member

@bwbarrett bwbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is only used for the polling frequency, works for me. We should do better before we revisit the MPI_Wtime debacle.

@bwbarrett bwbarrett merged commit c4ae36f into open-mpi:master Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants