Skip to content

v3.0.x: misc fixes for heterogeneous clusters #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 17, 2017
Merged

v3.0.x: misc fixes for heterogeneous clusters #3871

merged 6 commits into from
Jul 17, 2017

Conversation

ggouaillardet
Copy link
Contributor

No description provided.

@ggouaillardet ggouaillardet added this to the v3.0.0 milestone Jul 13, 2017
@ggouaillardet ggouaillardet requested a review from bosilca July 13, 2017 01:13
@bwbarrett
Copy link
Member

Why is the attribute handling patch required for heterogeneous clusters? That's an awful big change to bring into the v3.0.x series this late in the game.

@ggouaillardet
Copy link
Contributor Author

@bwbarret strictly speaking, the attribute handling patch is not required for heterogeneous clusters.

that being said, from #2940

the changes involves the prototype of a function pointer.
so there are several ways to see this.

  1. this breaks ABI
  2. this does not break ABI (the pointer size did not change)
  3. current implementation is broken anyway, so this really a bug fix, and since the pointer size did not change, this is an acceptable commit

i'd rather go with the latter option.

so if you are willing to accept the attribute handling patch for v3.0.1 (e.g. no or acceptable ABI break), then i am fine postponing it. but if this is now or in v4, then i'd rather do it now.

@bwbarrett
Copy link
Member

If it's not a heterogeneous fix, it shouldn't be in the list of heterogenous fixes. We can discuss whether the attribute patch is appropriate in a PR that just contains the attribute patch (since it sounds like it stands on its own).

@ggouaillardet
Revert "Remove --enable-heterogeneous until fix is ready"
485c60a 
This reverts commit open-mpi/ompi@2f4b3ab.

Signed-off-by: Gilles Gouaillardet <[email protected]>
@ggouaillardet
btl/tcp: fix heterogeneous support for put / large messages
912466b 
Signed-off-by: Gilles Gouaillardet <[email protected]>

(cherry picked from commit open-mpi/ompi@32606ad)
@ggouaillardet
oob/tcp: make mca_oob_tcp_msg_type_t an uint8_t
5846c57 
so no conversion is required when heterogeneous mode is enabled

Signed-off-by: Gilles Gouaillardet <[email protected]>

(cherry picked from commit open-mpi/ompi@626e94b)
@ggouaillardet
opal/ddt: use optimized description when packing contiguous datatypes
c4184ae 
Signed-off-by: Gilles Gouaillardet <[email protected]>

(cherry picked from commit open-mpi/ompi@9118777)
@ggouaillardet
opal/datatype: add minimal support to convert long double
cbaf3b6 
between ieee 754 quadruple precision and extended precision formats.

Signed-off-by: Gilles Gouaillardet <[email protected]>

(cherry picked from commit open-mpi/ompi@8fd08b9)
@ggouaillardet
opal/datatype: fix opal_dt_swap_long_double if no IEEE754_H
25a8e86 
Signed-off-by: Gilles Gouaillardet <[email protected]>

(cherry picked from commit open-mpi/ompi@a111fc8)
@ggouaillardet ggouaillardet force-pushed the topic/v3.0.x/hetero_fixes branch from e779c43 to 25a8e86 Compare July 14, 2017 00:15
@ggouaillardet
Copy link
Contributor Author

@bwbarrett i removed the attribute handling patch from this PR, and moved it in #3891

@bwbarrett bwbarrett merged commit 03c1511 into open-mpi:v3.0.x Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosilca bosilca bosilca approved these changes

Assignees

@bosilca bosilca

Labels
bug RM approved Target: v3.0.x
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ggouaillardet @bwbarrett @bosilca