sharedfp/sm: close the named semaphore #4352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgargabriel
force-pushed
the
pr/sem_close_fix
branch
from
9bf7cda to
d3fc3ac
Compare
|
I can confirm that using this patch a test open/closing an MPI File 2048 times finishes correctly without error messages on MacOS (which is not the case without this patch). |
| @@ -231,6 +231,10 @@ int mca_sharedfp_sm_file_open (struct ompi_communicator_t *comm, | |||
|
|
|||
| comm->c_coll->coll_barrier (comm, comm->c_coll->coll_barrier_module ); | |||
|
|
|||
| #if defined(HAVE_SEM_OPEN) | |||
| sem_unlink ( sm_data->sem_name); | |||
There was a problem hiding this comment.
should this only be invoked on (per node ?) rank zero ? that is likely harmless, but this should be invoked only once per node.
in case a named semaphore is used, it is necessary to close the semaphore to remove all sm segments. sem_unlink just removes the name references once all proceeses have closed the sem. Fixes issue: open-mpi#4336 Signed-off-by: Edgar Gabriel <[email protected]> sharedfp/sm: unlink only needs to be called by one process Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel
force-pushed
the
pr/sem_close_fix
branch
from
d3fc3ac to
4d995bd
Compare
|
@ggouaillardet , thank you, I fixed this. Can you please review again? |
|
looks good to me, thanks ! |
|
@ggouaillardet thank you. I created to pull requests of this patch for 3.0.1 and 3.1, if necessary, we can also create a patch for the 2.1.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case a named semaphore is used, it is necessary to close the semaphore to remove
all sm segments. sem_unlink just removes the name references once all proceeses have closed
the sem.
Fixes issue: #4336
Signed-off-by: Edgar Gabriel [email protected]