Disable the LSF plm if CSM is detected #4439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LSF running on top of CSM does not provide LSF daemons on the compute nodes. Signed-off-by: Matt Ezell <[email protected]>
|
Can one of the admins verify this patch? |
|
ok to test |
|
Sorry this got lost in the run up to SC. I'll try to get to it early this week. Sorry for the delay. |
gpaulsen
approved these changes
Nov 28, 2017
jjhursey
approved these changes
Nov 29, 2017
There was a problem hiding this comment.
This is good. Thanks!
There are some environments/setups where the CSM_ALLOCATION_ID might be set, but LSF can still be used to launch. However, there is no good way of detecting that scenario at the moment. We will work on a way to better detect that in a future PR.
|
@mattaezell Do you want this change in the three release branches ( |
|
Thanks @jjhursey. I'm not sure exactly what versions people are testing with here locally, let me check. |
This was referenced Dec 19, 2017
|
@mattaezell I filed PRs to take this to the v3.0.x and v3.1.x series. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSF running on top of CSM does not provide LSF daemons on the compute nodes. Attempts to run will result in errors like: