v3.0.x: fortran: Fix PMPI bugs in mpi_f08 module #4691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added missing Fortran 2008 binding pmpi_{*} subroutines to Open MPI.
Signed-off-by: Tsubasa Yanagibashi <[email protected]>
(cherry picked from commit 3f4b373)
Signed-off-by: KAWASHIMA Takahiro <[email protected]>
It was removed from only `mpi` as a bug fix in db41d74. Signed-off-by: KAWASHIMA Takahiro <[email protected]> (cherry picked from commit 9240967)
They were incorrectly changed to subroutines in only `pmpi` in 258d1aa. Strictly speaking, this change involves binary incompatibility. But nobody used these subroutines and nobody will be affected because these subroutines were useless (didn't return a calculated value). Signed-off-by: KAWASHIMA Takahiro <[email protected]> (cherry picked from commit d4fc404)
It was changed to use `C_PTR` in only `mpi` in fc69c0b. Signed-off-by: KAWASHIMA Takahiro <[email protected]> (cherry picked from commit 0c3a534)
It is incorrectly typed as `MPI_Comm` in only `pmpi` in 24f7bd3. Signed-off-by: KAWASHIMA Takahiro <[email protected]> (cherry picked from commit 056eb39)
This change makes comparison of `mpi-f08-interfaces.F90` and `pmpi-f08-interfaces.F90` easier. Signed-off-by: KAWASHIMA Takahiro <[email protected]> (cherry picked from commit 00e3c7a)
This is a bug which was forgotten to change in c08f97b. Signed-off-by: KAWASHIMA Takahiro <[email protected]> (cherry picked from commit bd2fe9c)
jsquyres
changed the title
jsquyres
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring PR #4659, #4667, #4668 to v3.0.x branch.
This PR includes an ABI change but no one will be affected (discussed in #4667).
NEWS: Correct PMPI_Aint_{add|diff} to be functions (not subroutines) in the Fortran mpi_f08 module.