Fix MPIR_proctable structure visibility #4891
Conversation
|
Ref #4892 |
|
looks ok to me - thx! |
orte/orted/Makefile.am
Outdated
| # post-processed forms of the CFLAGS in the library targets down | ||
| # below. | ||
|
|
||
| CFLAGS = $(CFLAGS_WITHOUT_OPTFLAGS) $(DEBUGGER_CFLAGS) |
There was a problem hiding this comment.
Hmm. It strikes me a bit of a bummer that we have to compile the entire orted without optimization flags.
Is there a way to segregate the needed symbols into a single, small .c file and compile only that file without optimization flags?
There was a problem hiding this comment.
one option you could consider - if you get people to use "prun" for executing jobs under the DVM, then the debugger code and orted_submit stuff could go back into orterun. It would take a little work to move it, but not too horrible.
There was a problem hiding this comment.
fwiw, I made a proof of concept, and the -g flag only has to be passed to orte/orted/orted_submit.lo, orte/libopen-rte.la and orte/tools/orted/orted
the inline patch below addresses the last two ones, but I could not figure out how to pass that flag to orted_submit.lo (orte/orted/Makefile.am is included in orte/Makefile.am, so the "object" file is orted/orted_submit.lo and I do not know how to handle the / in Makefile.am
diff --git a/orte/Makefile.am b/orte/Makefile.am
index 6af81a2..c9d27bc 100644
--- a/orte/Makefile.am
+++ b/orte/Makefile.am
@@ -41,7 +41,7 @@ lib@ORTE_LIB_PREFIX@open_rte_la_LIBADD = \
$(MCA_orte_FRAMEWORK_LIBS) \
$(ORTE_TOP_BUILDDIR)/opal/lib@[email protected]
lib@ORTE_LIB_PREFIX@open_rte_la_DEPENDENCIES = $(libopen_rte_la_LIBADD)
-lib@ORTE_LIB_PREFIX@open_rte_la_LDFLAGS = -version-info $(libopen_rte_so_version)
+lib@ORTE_LIB_PREFIX@open_rte_la_LDFLAGS = -version-info $(libopen_rte_so_version) $(DEBUGGER_CFLAGS)
# included subdirectory Makefile.am's and appended-to variables
headers =
diff --git a/orte/tools/orted/Makefile.am b/orte/tools/orted/Makefile.am
index 92211a3..32fe2bc 100644
--- a/orte/tools/orted/Makefile.am
+++ b/orte/tools/orted/Makefile.am
@@ -43,7 +43,7 @@ orted_SOURCES = orted.c
# nothing to -all-static in the Makefile.in
# nice for systems that don't have all the shared
# libraries on the computes
-orted_LDFLAGS =
+orted_LDFLAGS = $(DEBUGGER_CFLAGS)
orted_LDADD = \
$(top_builddir)/orte/lib@[email protected] \
$(top_builddir)/opal/lib@[email protected]There was a problem hiding this comment.
We can use this trick to compile just orted_submit.c with debug symbols. Let me give that a try.
If we want to further narrow down how much of orted_submit.c is compiled this way, we can do that in another effort.
jjhursey
force-pushed
the
fix/mpir-symbol-vis
branch
from
f673e60 to
f551bfc
Compare
* The `MPIR_PROCDESC` structure needs to be visible even in optimized
builds so that debuggers can attach to `mpirun` and properly read the
`MPIR_proctable`.
* In the v2.0.x and v2.x series this structure resided in the `orterun`
directory and included the `CFLAGS` fix included here. This code
moved in the v3.x series and the `CFLAGS` did not move causing this
issue.
- Instead of applying the debug `CFLAGS` globally to libopen-rte,
only apply them to the `orted_submit.c` compile which contains the
MPIR symbols.
Signed-off-by: Joshua Hursey <[email protected]>
jjhursey
force-pushed
the
fix/mpir-symbol-vis
branch
from
f551bfc to
ccb4f43
Compare
|
@ggouaillardet @jsquyres I changed the PR to isolate the debug symbols to just the compilation of I confirmed that this patch does fix the MPIR test case. |
|
@jjhursey very clever ! |
MPIR_PROCDESCstructure needs to be visible even in optimizedbuilds so that debuggers can attach to
mpirunand properly read theMPIR_proctable.orterundirectory and included the
CFLAGSfix included here. This codemoved in the v3.x series and the
CFLAGSdid not move causing thisissue.