v3.1: config/opal_setup_java.m4: Improve JDK tool path resolution on OS X/… #5118
Conversation
…acOS. Also avoid picking up Apple's Java shims via the sym. links to them in `/usr/bin` on systems where any one of them could possibly exhibit behavior that is erratic and, to some extent, likely to be incorrect nowadays (cf.: - https://www.mail-archive.com/[email protected]/msg20551.html - open-mpi#5015 (comment) - the last part of open-mpi#5015 (comment) - open-mpi#5015 (comment) for more detailed context.) Works alongside open-mpi#5001 to close open-mpi#5000. Signed-off-by: Bryce Glover <[email protected]> (cherry picked from commit open-mpi/ompi@8c32cd8)
|
This PR should be part of v3.1.0, not v3.1.1, if at all possible because the earlier release also includes #5028, which contains a change that goes together with the one backported by this PR, already. (Both this change and that one are needed on all relevant release tracks to resolve #5000. Pending backport PR review, both changes' v3.0.x counterparts should similarly both be part of v3.0.2.) |
|
@RandomDSdevel, sorry, at this point, 3.1.0 is baked. This patch will make 3.1.1. |
|
@RandomDSdevel 3.1.1 will be a somewhat-quick turnaround (let's estimate a month?). |
There was a problem hiding this comment.
Looks good to me, but I'd also like to get @kawashima-fj's review.
jsquyres
changed the title
|
Per #5001 (comment), do not merge yet. |
|
@ggouaillardet Can you cherry pick 4a05c7e on to this PR? |
That PR accidentally changed Open MPI's build configuration infrastruc- ture's Java toolchain detection logic so that it would, as reported by @bosilca in open-mpi#5001 (comment) and tracked down by me in open-mpi#5001 (comment), abort your entire in-progress Open MPI build when it failed to find an OS X/macOS JDK instead of simply falling back to checking for a JDK in locations where it would be found on other platforms. _Oops…!_ Signed-off-by: Bryce Glover <[email protected]> (cherry picked from commit open-mpi/ompi@4a05c7e)
|
@jsquyres done ! |
…macOS.
Also avoid picking up Apple's Java shims via the sym. links to them in
/usr/binon systems where any one of them could possibly exhibit behaviorthat is erratic and, to some extent, likely to be incorrect nowadays (cf.:
config/opal_setup_java.m4: Improve JDK Tool Path Resolution on OS X/macOS #5015 (comment)
for more detailed context.)
Works alongside #5001 to close #5000.
Signed-off-by: Bryce Glover [email protected]
(cherry picked from commit 8c32cd8)