v3.0: config/opal_setup_java.m4: Improve JDK tool path resolution on OS X/… #5119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acOS. Also avoid picking up Apple's Java shims via the sym. links to them in `/usr/bin` on systems where any one of them could possibly exhibit behavior that is erratic and, to some extent, likely to be incorrect nowadays (cf.: - https://www.mail-archive.com/[email protected]/msg20551.html - open-mpi#5015 (comment) - the last part of open-mpi#5015 (comment) - open-mpi#5015 (comment) for more detailed context.) Works alongside open-mpi#5001 to close open-mpi#5000. Signed-off-by: Bryce Glover <[email protected]> (cherry picked from commit open-mpi/ompi@8c32cd8)
jsquyres
changed the title
jsquyres
approved these changes
May 4, 2018
There was a problem hiding this comment.
Looks good to me, but I'd also like to get @kawashima-fj's review.
kawashima-fj
approved these changes
May 7, 2018
|
Per #5001 (comment), there is a problem with this PR. It may need to be reverted and/or amended. |
hppritcha
added a commit
that referenced
this pull request
May 10, 2018
v3.0.x: Fix config/opal_setup_java.m4 from commit merged in #5119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…macOS.
Also avoid picking up Apple's Java shims via the sym. links to them in
/usr/binon systems where any one of them could possibly exhibit behaviorthat is erratic and, to some extent, likely to be incorrect nowadays (cf.:
config/opal_setup_java.m4: Improve JDK Tool Path Resolution on OS X/macOS #5015 (comment)
for more detailed context.)
Works alongside #5001 to close #5000.
Signed-off-by: Bryce Glover [email protected]
(cherry picked from commit 8c32cd8)