Skip to content

COMMON/UCX: suppressed coverity warnings - v4.0 #5956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

COMMON/UCX: suppressed coverity warnings - v4.0 #5956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcf20a6
COMMON/UCX: suppressed coverity warnings
Oct 17, 2018
8ff213e
COMMON/UCX: added error code to log output
Oct 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ompi/mca/osc/ucx/osc_ucx_active_target.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,10 @@ int ompi_osc_ucx_complete(struct ompi_win_t *win) {
OSC_UCX_VERBOSE(1, "ucp_atomic_post failed: %d", status);
}

opal_common_ucx_ep_flush(ep, mca_osc_ucx_component.ucp_worker);
ret = opal_common_ucx_ep_flush(ep, mca_osc_ucx_component.ucp_worker);
if (OMPI_SUCCESS != ret) {
OSC_UCX_VERBOSE(1, "opal_common_ucx_ep_flush failed: %d", ret);
}
}

OBJ_RELEASE(module->start_group);
Expand Down
5 changes: 4 additions & 1 deletion ompi/mca/osc/ucx/osc_ucx_component.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,10 @@ int ompi_osc_ucx_free(struct ompi_win_t *win) {
ucp_worker_progress(mca_osc_ucx_component.ucp_worker);
}

opal_common_ucx_worker_flush(mca_osc_ucx_component.ucp_worker);
ret = opal_common_ucx_worker_flush(mca_osc_ucx_component.ucp_worker);
if (OMPI_SUCCESS != ret) {
OSC_UCX_VERBOSE(1, "opal_common_ucx_worker_flush failed: %d", ret);
}

ret = module->comm->c_coll->coll_barrier(module->comm,
module->comm->c_coll->coll_barrier_module);
Expand Down
2 changes: 1 addition & 1 deletion ompi/mca/pml/ucx/pml_ucx_datatype.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ int mca_pml_ucx_datatype_attr_del_fn(ompi_datatype_t* datatype, int keyval,
{
ucp_datatype_t ucp_datatype = (ucp_datatype_t)attr_val;

PML_UCX_ASSERT((void*)ucp_datatype == datatype->pml_data);
PML_UCX_ASSERT((uint64_t)ucp_datatype == datatype->pml_data);

ucp_dt_destroy(ucp_datatype);
datatype->pml_data = PML_UCX_DATATYPE_INVALID;
Expand Down
10 changes: 9 additions & 1 deletion opal/mca/common/ucx/common_ucx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ OPAL_DECLSPEC void opal_common_ucx_mca_var_register(const mca_base_component_t *

OPAL_DECLSPEC void opal_common_ucx_mca_register(void)
{
int ret;

opal_common_ucx.registered++;
if (opal_common_ucx.registered > 1) {
/* process once */
Expand All @@ -89,7 +91,13 @@ OPAL_DECLSPEC void opal_common_ucx_mca_register(void)
opal_common_ucx.output = opal_output_open(NULL);
opal_output_set_verbosity(opal_common_ucx.output, opal_common_ucx.verbose);

mca_base_framework_open(&opal_memory_base_framework, 0);
ret = mca_base_framework_open(&opal_memory_base_framework, 0);
if (OPAL_SUCCESS != ret) {
/* failed to initialize memory framework - just exit */
MCA_COMMON_UCX_VERBOSE(1, "failed to initialize memory base framework: %d, "
"memory hooks will not be used", ret);
return;
}

/* Set memory hooks */
if (opal_common_ucx.opal_mem_hooks &&
Expand Down