OSHMEM: added missing API for get/put operations #6168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manjugv
reviewed
Dec 7, 2018
| #define shmem_uint32_p pshmem_uint32_p | ||
| #define shmem_uint64_p pshmem_uint64_p | ||
| #define shmem_size_p pshmem_size_p | ||
| #define shmem_ptrdiff_p pshmem_ptrdiff_p | ||
|
|
||
| #define shmemx_int16_p pshmemx_int16_p | ||
| #define shmemx_int32_p pshmemx_int32_p |
There was a problem hiding this comment.
@hoopoepg Do you still need this ?
There was a problem hiding this comment.
Actually not, but backward compatibility...
manjugv
reviewed
Dec 7, 2018
| #define shmem_uint32_g pshmem_uint32_g | ||
| #define shmem_uint64_g pshmem_uint64_g | ||
| #define shmem_size_g pshmem_size_g | ||
| #define shmem_ptrdiff_g pshmem_ptrdiff_g | ||
|
|
||
| #define shmemx_int16_g pshmemx_int16_g | ||
| #define shmemx_int32_g pshmemx_int32_g |
There was a problem hiding this comment.
Didn't removed this to not break existing software where this API is used
- added calls for datatypes int/uint/8/16/32/size/ptrdiff for shmem_g/get/iget/get_nbi/_p/put/iput/put_nbi Signed-off-by: Sergey Oblomov <[email protected]>
hoopoepg
force-pushed
the
topic/get-put-int-uint-8-16-32
branch
from
a1c8191 to
cfa9150
Compare
yosefe
approved these changes
Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for shmem_g/get/iget/get_nbi/_p/put/iput/put_nbi
Signed-off-by: Sergey Oblomov [email protected]