v4.0.x: oob/tcp: add cross version compatibility support #6380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we intend to provide cross version compatibility between versions with the same major and minor, use MAJOR.MINOR.0 instead of orte_version_string (e.g. MAJOR.MINOR.RELEASEGREEK). Open MPI 4.0.0 has already been released, so in order to make it compatible with future 4.0.x releases, we have to use 4.0.0 as the version string, that is why we use MAJOR.MINOR.0 instead of MAJOR.MINOR Signed-off-by: Gilles Gouaillardet <[email protected]>
|
Do we want to make this more general and just check Major, so 4.1 and 4.0 can hopefully talk to each other @ggouaillardet 's "half way" approach for using containers with Open MPI? |
|
IIRC, the conclusion of the telecon was to indeed only check the major number, and we will separate that from the ORTE_MAJOR_VERSION - i.e., change the code so we only pass/check "4". We will update that number if/when there is a change that impacts the oob wire protocol. |
|
This PR -- and the master PR #6157 -- does not reflect that decision. |
Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
ggouaillardet-topic/oob_tcp_cross_version_compatibility
branch
from
2696237 to
de1dd1c
Compare
|
The IBM CI (XL Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6 |
jsquyres
changed the title
rhc54
approved these changes
Feb 13, 2019
hppritcha
deleted the
ggouaillardet-topic/oob_tcp_cross_version_compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we intend to provide cross version compatibility
between versions with the same major and minor, use
MAJOR.MINOR.0 instead of orte_version_string
(e.g. MAJOR.MINOR.RELEASEGREEK).
Open MPI 4.0.0 has already been released, so in order to make
it compatible with future 4.0.x releases, we have to use 4.0.0
as the version string, that is why we use MAJOR.MINOR.0 instead
of MAJOR.MINOR
Relates to #6157
Signed-off-by: Gilles Gouaillardet [email protected]