PML/UCX: Use net worker address for remote peers - v4.0.x #6395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
yosefe
approved these changes
Feb 18, 2019
|
@jsquyres @hppritcha ok to merge? |
jsquyres
previously requested changes
Feb 21, 2019
|
@brminich Thanks. Please add the usual cherry pick message to the commit (you can do this via |
For remote node peers pack smaller worker address, which contains network device addresses only. This would reduce amount of OOB traffic during startup. Signed-off-by: Mikhail Brinskii <[email protected]> (cherry picked from commit 751d881)
brminich
force-pushed
the
topic/ucx_net_waddr_4.0.x
branch
from
104b9a5 to
1c51494
Compare
|
@jsquyres, done |
jsquyres
dismissed
their stale review
Got the cherry pick from master in the commit message now
|
@brminich Thanks. That just helps us track to a) make sure things went in on master first, and b) make sure that what went on master also made it to relevant release branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For remote node peers pack smaller worker address, which contains
network device addresses only. This would reduce amount of OOB traffic
during startup.
Signed-off-by: Mikhail Brinskii [email protected]
(cherry picked from commit 751d881)