OSC rdma: make sure accumulating in shared memory is safe #6649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseph Schuchart <[email protected]>
|
Can one of the admins verify this patch? |
|
ok to test |
|
@devreal could you PR this over to 4.0.x? |
hppritcha
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the peer is reachable through shared memory there may still be remote peers updating directly through the network, which leads to conflicting updates, i.e., if
osc_rdma_acc_single_intrinsicis set. This PR adds more thorough checks to make sure it's safe to accumulate in shared memory.Fixes #6536
Signed-off-by: Joseph Schuchart [email protected]