Skip to content

ALLOC_WITH_HINT: added inplace realloc - v4.0 #6707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hoopoepg
Copy link
Contributor

  • in some cases realloc operation may be completed without
  • allocation of new buffer (and without additional data copy)
    added logic to reallocate buffer inplace if possible

backport from #6667

Sergey Oblomov added 3 commits May 27, 2019 11:44
- in some cases realloc operation may be completed without
  allocation of new buffer (and without additional data copy)
- added logic to reallocate buffer inplace if possible

Signed-off-by: Sergey Oblomov <[email protected]>
(cherry picked from commit 277c2a9)
Signed-off-by: Sergey Oblomov <[email protected]>
(cherry picked from commit a51badd)
Signed-off-by: Sergey Oblomov <[email protected]>
(cherry picked from commit d6a0912)
@hoopoepg hoopoepg added this to the v4.0.2 milestone May 27, 2019
@hoopoepg hoopoepg requested a review from yosefe May 27, 2019 10:24
@AboorvaDevarajan
Copy link
Member

Can one of the admins verify this patch?

@yosefe
Copy link
Contributor

yosefe commented Jun 3, 2019

@hppritcha ok to merge?

@jsquyres
Copy link
Member

jsquyres commented Jun 3, 2019

@AboorvaDevarajan Not quite sure what you were asking...? The phrase "Can one of the admins verify this patch?" is usually posted by our Jenkins system when a github user who is not part of the open-mpi community submits a pull request. When a member of the github open-mpi community replies with "ok to test", Jenkins then actually submits the CI job. It's an anti-DOS system (i.e., vs. overwhelming our CI system with a flood of junk PRs).

@AboorvaDevarajan
Copy link
Member

@jsquyres I failed to disable the default notifications in one of the Jenkins CI job bot that I was running, the job polled and added comments in a few PRs automatically, I disabled it right away. Will be extra cautious when enabling such things. Thanks.

@jsquyres
Copy link
Member

jsquyres commented Jun 3, 2019

Oh, gotcha -- that wasn't you posting those comments; it was a bot running with your credentials. That makes much more sense! 😄

@gpaulsen gpaulsen requested a review from hppritcha June 3, 2019 19:57
@hoopoepg
Copy link
Contributor Author

hoopoepg commented Jun 4, 2019

bot:retest

@gpaulsen
Copy link
Member

gpaulsen commented Jun 5, 2019

The UH CI appears to be offline. Let's see if a new round of CI will fix the issue...

bot:retest

@hppritcha hppritcha merged commit a42977f into open-mpi:v4.0.x Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants