-
Notifications
You must be signed in to change notification settings - Fork 901
Updating VERSION for v4.0.2rc1 #6925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
looks like cori file system is really slow, try again |
VERSION
Outdated
@@ -3,9 +3,9 @@ | |||
# Copyright (c) 2011 NVIDIA Corporation. All rights reserved. | |||
# Copyright (c) 2013 Mellanox Technologies, Inc. | |||
# All rights reserved. | |||
# Copyright (c) 2017 Los Alamos National Security, LLC. All rights | |||
# Copyright (c) 2017-2019 Los Alamos National Security, LLC. All rights |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpaulsen if you want to update VERSION for Los alamos, we have a new company operating the lab. git grep for triad in some other files and you'll see the right attribution. Or I can fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can fix.
VERSION
Outdated
libmca_ompi_common_monitoring_so_version=60:0:10 | ||
|
||
# ORTE layer | ||
libmca_orte_common_alps_so_version=60:0:20 | ||
libmca_orte_common_alps_so_version=60:1:20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any changes to files for common_alps_so. I think it should stay at rev=0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did see this change, so I bumped the age. Perhaps this doesn't warrant an age bump?
diff --git a/orte/mca/ess/alps/ess_alps_module.c b/orte/mca/ess/alps/ess_alps_module.c
index 533a054e..bfbbc3d9 100644
--- a/orte/mca/ess/alps/ess_alps_module.c
+++ b/orte/mca/ess/alps/ess_alps_module.c
@@ -45,7 +45,7 @@ static int rte_finalize(void);
orte_ess_base_module_t orte_ess_alps_module = {
rte_init,
rte_finalize,
- orte_ess_base_app_abort,
+ NULL,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not usually as it isn't an interface in the common/alps library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I figured that out after looking at it again.
c94fa50
to
17d6894
Compare
Signed-off-by: Geoffrey Paulsen <[email protected]>
17d6894
to
b07d58a
Compare
Updating VERSION file for v4.0.2rc1
Signed-off-by: Geoffrey Paulsen [email protected]