Skip to content

Updating VERSION for v4.0.2rc1 #6925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Conversation

gpaulsen
Copy link
Member

Updating VERSION file for v4.0.2rc1

Signed-off-by: Geoffrey Paulsen [email protected]

@gpaulsen gpaulsen requested a review from hppritcha August 23, 2019 20:38
@gpaulsen gpaulsen added this to the v4.0.2 milestone Aug 23, 2019
@hppritcha
Copy link
Member

looks like cori file system is really slow, try again
bot:ompi:retest

VERSION Outdated
@@ -3,9 +3,9 @@
# Copyright (c) 2011 NVIDIA Corporation. All rights reserved.
# Copyright (c) 2013 Mellanox Technologies, Inc.
# All rights reserved.
# Copyright (c) 2017 Los Alamos National Security, LLC. All rights
# Copyright (c) 2017-2019 Los Alamos National Security, LLC. All rights
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpaulsen if you want to update VERSION for Los alamos, we have a new company operating the lab. git grep for triad in some other files and you'll see the right attribution. Or I can fix this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can fix.

VERSION Outdated
libmca_ompi_common_monitoring_so_version=60:0:10

# ORTE layer
libmca_orte_common_alps_so_version=60:0:20
libmca_orte_common_alps_so_version=60:1:20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes to files for common_alps_so. I think it should stay at rev=0

Copy link
Member Author

@gpaulsen gpaulsen Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did see this change, so I bumped the age. Perhaps this doesn't warrant an age bump?

diff --git a/orte/mca/ess/alps/ess_alps_module.c b/orte/mca/ess/alps/ess_alps_module.c
index 533a054e..bfbbc3d9 100644
--- a/orte/mca/ess/alps/ess_alps_module.c
+++ b/orte/mca/ess/alps/ess_alps_module.c
@@ -45,7 +45,7 @@ static int rte_finalize(void);
 orte_ess_base_module_t orte_ess_alps_module = {
     rte_init,
     rte_finalize,
-    orte_ess_base_app_abort,
+    NULL,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not usually as it isn't an interface in the common/alps library

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I figured that out after looking at it again.

@gpaulsen gpaulsen force-pushed the v4.0.x_VERSION_rc1 branch from c94fa50 to 17d6894 Compare August 24, 2019 18:14
Signed-off-by: Geoffrey Paulsen <[email protected]>
@gpaulsen gpaulsen force-pushed the v4.0.x_VERSION_rc1 branch from 17d6894 to b07d58a Compare August 24, 2019 18:16
@gpaulsen gpaulsen requested a review from hppritcha August 24, 2019 20:18
@gpaulsen gpaulsen merged commit 5744811 into open-mpi:v4.0.x Aug 26, 2019
@gpaulsen gpaulsen deleted the v4.0.x_VERSION_rc1 branch August 26, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants