Small optimization on the datatype commit. #6945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the merge of contiguous elements into larger but more compact datatypes, and allows for contiguous elements to have thir blocklen increasing instead of the count. The idea is to always maximize the blocklen, aka. the contiguous part of the datatype. Signed-off-by: George Bosilca <[email protected]>
elements that can be merged into a larger UINT1 type. Signed-off-by: George Bosilca <[email protected]>
bosilca
force-pushed
the
topic/ddt_optimize
branch
from
ebe7ed6 to
82d6322
Compare
|
I was able to track back the issue by looking at the datatype from issue #6932. It failed to merge into a single predefined element but the datatype was marked as contiguous, allowing the datatype engine to use one of the optimized pack/unpack function (contig_with_gaps). However, having a composed description mislead the contig_with_gaps function to wrongly interpret the shape of the datatype. Anyway, long story short, this patch fixes the issue and add a test to prevent it from happening in the future. Once merged it should be backported to v3 and v4. |
|
@bosilca Any particular reason not to merge this PR? |
|
It need to be backported but I don't have time to do it right now. Feel free to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the merge of contiguous elements into larger but more
compact datatypes, and allows for contiguous elements to have thir
blocklen increasing instead of the count. The idea is to always maximize
the blocklen, aka. the contiguous part of the datatype.
Possible fix for #6932
Signed-off-by: George Bosilca [email protected]