v3.1.x: UCX osc: properly release exclusive lock to avoid lockup #6972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseph Schuchart <[email protected]> (cherry picked from commit a5cc380)
|
cori may need to be taken off line - try again |
|
Can we get this into the next v3.1.x release? Should it cherry-picked to 3.0.x as well? |
|
This wasn't labeled or milestoned, so I didn't see it until now... Needs a review (ASAP). |
jsquyres
changed the title
|
@devreal will do this week. |
janjust
approved these changes
Oct 23, 2019
|
@artpol84 please review. |
|
Will do today, sorry for the delay |
artpol84
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Looks good to me.
I wonder if after this change we should revisit the shared lock acquisition link.
Instead of looping over
taken = 0;
while(!taken){
val = atomic_inc(var);
if( val > EXCLUSIVE ) {
atomic_dec(var);
} else {
taken = 1;
}
}we can now
val = atomic_inc(var);
while( val > EXCLUSIVE ) {
val = atomic_read(val); // or just read
}Need to see if this will be faster.
|
@yosefe, what do you think regarding the next step above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #6933 to v3.1.x
See #6931 for the issue this fixes.
Signed-off-by: Joseph Schuchart [email protected]
(cherry picked from commit a5cc380)