v4.0.x: Conform MPIR_Breakpoint to MPIR standard. #6990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix MPIR_Breakpoint standard violation by returning void instead of a void*. Signed-off-by: Austen Lauria <[email protected]> (cherry picked from commit 067adfa)
jsquyres
changed the title
jsquyres
requested changes
Sep 18, 2019
There was a problem hiding this comment.
@awlauria I'm sorry, this is just the issue that won't die. 😦 Turns out that @rhc54 was right: this symbol is turning up as a public symbol in the ORTE library; we can't have an un-prefixed public symbol in the library. Can you make another PR for master to make the symbol start with orte_? Sorry...
$ nm ~/bogus2/lib/libopen-rte.so | grep noop
00000000002b3d00 B noop_mpir_breakpoint_ptr
Signed-off-by: Austen Lauria <[email protected]> (cherry picked from commit 7714468)
jsquyres
approved these changes
Sep 19, 2019
|
@hppritcha I think this is now ready to merge to v4.0.x. Do you concur? |
hppritcha
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of a void*.
Signed-off-by: Austen Lauria [email protected]
(cherry picked from commit 067adfa)