Cleanup stale code in ORTE/OOB #7010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove code for multiple OOB progress threads as it is an optimization nobody uses. Also turns out to have a race condition that can cause segfault on finalize, so maybe good that nobody is using it. Signed-off-by: Ralph Castain <[email protected]>
|
I confirm that this is definitely causing a problem for me and at least one of my customers on the v3.1.x branch. A cherry-pick PR will be coming shortly... |
This was referenced Sep 25, 2019
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Sep 30, 2019
need orte_oob_base ev_base to be set to some valid address to keep libevent happy. This partially reverts open-mpi#7010. Signed-off-by: Howard Pritchard <[email protected]>
rhc54
added a commit
to rhc54/prrte
that referenced
this pull request
Dec 5, 2019
Signed-off-by: Ralph Castain <[email protected]>
rhc54
added a commit
to rhc54/prrte
that referenced
this pull request
Dec 7, 2019
Signed-off-by: Ralph Castain <[email protected]> Next round Signed-off-by: Ralph Castain <[email protected]> touchups Signed-off-by: Ralph Castain <[email protected]> continue Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Update VERSION Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Pass configure Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Remove last vestiges of OPAL Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Bring over OOB changes from open-mpi/ompi#7010 Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Rename help text file Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Compile Signed-off-by: Ralph Castain <[email protected]> minor cleanups Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]>
rhc54
added a commit
to rhc54/prrte
that referenced
this pull request
Dec 9, 2019
Signed-off-by: Ralph Castain <[email protected]> Next round Signed-off-by: Ralph Castain <[email protected]> touchups Signed-off-by: Ralph Castain <[email protected]> continue Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Update VERSION Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Pass configure Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Remove last vestiges of OPAL Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Bring over OOB changes from open-mpi/ompi#7010 Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Rename help text file Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Compile Signed-off-by: Ralph Castain <[email protected]> minor cleanups Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Getting closer Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]>
rhc54
added a commit
to rhc54/prrte
that referenced
this pull request
Dec 10, 2019
Signed-off-by: Ralph Castain <[email protected]> Next round Signed-off-by: Ralph Castain <[email protected]> touchups Signed-off-by: Ralph Castain <[email protected]> continue Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Update VERSION Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Pass configure Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Remove last vestiges of OPAL Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Bring over OOB changes from open-mpi/ompi#7010 Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Rename help text file Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Compile Signed-off-by: Ralph Castain <[email protected]> minor cleanups Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> Getting closer Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]> ckpt Signed-off-by: Ralph Castain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code for multiple OOB progress threads as it is an optimization
nobody uses. Also turns out to have a race condition that can cause
segfault on finalize, so maybe good that nobody is using it.
Signed-off-by: Ralph Castain [email protected]