Skip to content

v3.1.x: Cleanup stale code in ORTE/OOB #7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2019
Merged

v3.1.x: Cleanup stale code in ORTE/OOB #7013

merged 2 commits into from
Sep 26, 2019

Conversation

rhc54
Copy link
Contributor

@rhc54 rhc54 commented Sep 25, 2019

Remove code for multiple OOB progress threads as it is an optimization
nobody uses. Also turns out to have a race condition that can cause
segfault on finalize, so maybe good that nobody is using it.

Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit 41eb41c)

@rhc54 rhc54 added this to the v3.1.5 milestone Sep 25, 2019
@rhc54 rhc54 requested a review from jsquyres September 25, 2019 21:24
@rhc54 rhc54 self-assigned this Sep 25, 2019
@jsquyres jsquyres changed the title Cleanup stale code in ORTE/OOB v3.1.x: Cleanup stale code in ORTE/OOB Sep 25, 2019
Remove code for multiple OOB progress threads as it is an optimization
nobody uses. Also turns out to have a race condition that can cause
segfault on finalize, so maybe good that nobody is using it.

Signed-off-by: Ralph Castain <[email protected]>
(cherry picked from commit 41eb41c)
Signed-off-by: Ralph Castain <[email protected]>
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested empirically.

@jsquyres jsquyres merged commit cfffc9c into open-mpi:v3.1.x Sep 26, 2019
@rhc54 rhc54 deleted the cmr31/oob branch November 27, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants