Reachable documentation change #7167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wckzhang
force-pushed
the
reachable_netlinks
branch
from
a15c954 to
25c0438
Compare
jsquyres
reviewed
Nov 14, 2019
opal/mca/reachable/reachable.h
Outdated
| @@ -75,6 +75,8 @@ typedef int (*opal_reachable_base_module_fini_fn_t)(void); | |||
| * interfaces, but only a (comparable) reachability between any pair | |||
| * of local/remote interfaces. | |||
| * | |||
| * This function will show an identical local and remote interface as | |||
| * reachable through loopback. | |||
There was a problem hiding this comment.
Nit pick: it will show it as reachable -- I don't think the "reachable" framework indicates / implies which interface the traffic will actually go through, right?
There was a problem hiding this comment.
That's true, I'll change it to just say "as reachable".
wckzhang
force-pushed
the
reachable_netlinks
branch
from
25c0438 to
f1b22fe
Compare
|
@markalle Can you confirm that this patch combined with my previous one fixes your issue? Thanks. |
bwbarrett
requested changes
Nov 26, 2019
| @@ -112,6 +112,15 @@ static int get_weights(opal_if_t *local_if, opal_if_t *remote_if) | |||
| remote_ip = (uint32_t)((struct sockaddr_in *)&(remote_if->if_addr))->sin_addr.s_addr; | |||
| outgoing_interface = local_if->if_kernel_index; | |||
|
|
|||
| /* If the ips are identical, assume reachable through loopback */ | |||
There was a problem hiding this comment.
Can you add a bit more of a comment here? Say that we're doing something artificial because historical reasons. Someone in 2 years is going to wonder why this comment is here.
There was a problem hiding this comment.
I updated the comment.
Due to the way netlinks detects reachability, it will not show an interface as reachable to itself, even if it can pass through a loopback interface. To maintain similar behavior with netmasks, we display an interface as reachable to itself. Signed-off-by: William Zhang <[email protected]>
We have decided to show interfaces that are identical to itself as reachable. This is consistent with the previous netmask logic when determining reachability. Signed-off-by: William Zhang <[email protected]>
wckzhang
force-pushed
the
reachable_netlinks
branch
from
f1b22fe to
a471f87
Compare
bwbarrett
approved these changes
Dec 19, 2019
bosilca
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are changing the documentation and promised behavior of the reachability framework and changing the netlinks component to match.
See more details in #7134