Pr/sharedfp sm logic3 #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tried to unify the named and unnamed semaphore logic.
…he Open MPI naming convention
Change the code to rely on HAVE_SEM_OPEN etc. instead of my internal macro.
|
@edgargabriel Thanks -- the separate commits made this much easier to review. FWIW, you could have used the same/existing PR -- just force-push your new/replacement commits to the old PR. Github will do the Right Thing -- it'll update your PR with the new commits (because the PR is based on the branch, so Github will notice when the branch changes). Note that this is just about the only acceptable case for using a force push. :-) |
Even if the mutex is actually located in sm_data->sm_offset_ptr->mutex, have sm_data->mutex point to it. This avoids a few #if blocks that are otherwise identical.
No code changes. Replace tabs with spaces and do other whitespace cleanup (via emacs).
Commits on top of open-mpi#745
|
I pulled in two commits from Jeff, and tested and can confirm that they work correctly. Will merge the pr now. |
Closed
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
…gure-logic Merge pull request open-mpi#745 from edgargabriel/pr/sharedfp-sm-logic3
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
usnic: fix/update the usnic stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jsquyres , I redid the entire branch and pull request and I think I incoroporated all your comments/requests except for the two mutex. TO be more detailed:
If you have chance, please have a look at it.