Java garbage collection bugfix #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request adds an arraylist of type Buffer to the Request class. Whenever a request object is created that has associated buffers, the buffers should be added to this array list so the java garbage collector does not dispose of the buffers prematurely. This is a more robust expansion on the idea first proposed by @ggouaillardet Fixes open-mpi#369 Signed-off-by: Nathaniel Graham <[email protected]>
| MPI.check(); | ||
| return new Comm(dupWithInfo(handle, info.handle)); | ||
| MPI.check(); | ||
| return new Comm(dupWithInfo(handle, info.handle)); |
There was a problem hiding this comment.
minor thing, and don't redo for this PR, but normally try to avoid whitespace changes in PRs that are not just whitespace changes.
|
👍 |
|
@nrgraham23 please push this fix back to v1.10. |
Removing the ArrayList import which is no longer needed.
hppritcha
added a commit
that referenced
this pull request
Aug 22, 2015
Java garbage collection bugfix
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Sep 19, 2016
1.10 osc sm fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two Buffer references to the
Request class. Whenever a request object is created
that has associated buffers, the buffers should be added
to these references so the java garbage collector does
not dispose of the buffers prematurely.
This is a more robust expansion on the idea first proposed by
@ggouaillardet, and further discussed in #369.
Fixes #369
Signed-off-by: Nathaniel Graham [email protected]
@hppritcha @jsquyres @ggouaillardet @osvegis