treematch: use rename.h to properly prefix treematch symbols #8388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefix all the not-intended-to-be-public treematch symbols with "ompi_tm_" so that they don't pollute the Open MPI library namespace. Also, mark a bunch of symbols as "static" that are not used outside of their respective .c files to prevent pollution of internal treematch symbols in the Open MPI library. Signed-off-by: Jeff Squyres <[email protected]>
|
Per verbal discussion with @bosilca, the treematch authors have a new version of treematch that will entail some re-coding on our side to adapt to their new API / changes. Hence, it's "safe" to locally edit our treematch library because upstream has already diverged from us. If we don't plan to re-sync with upstream (i.e., port to their new API), we can make changes to our local treematch without consequence. |
|
The IBM CI (XL) build failed! Please review the log, linked below. Gist: https://gist.github.com/3a080052062345c652734f265cab41cb |
|
@jsquyres Is this important for v5.0.0 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefix all the not-intended-to-be-public treematch symbols with
"ompi_tm_" so that they don't pollute the Open MPI library namespace.
Also, mark a bunch of symbols as "static" that are not used outside of
their respective .c files to prevent pollution of internal treematch
symbols in the Open MPI library.
Signed-off-by: Jeff Squyres [email protected]
This is related to #8262 and #8132.