Skip to content

v4.1.x: Use newer config.guess / config.sub files when relevant #8421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jsquyres
Copy link
Member

Refs #8410.

This is the v4.1.x equivalent of master PR #8417.

I chose to leave the reference to the "3rd-party" tree in the code, even though that directory does not exist in the v4.1.x branch. It just makes the cherry-pick cleaner.

See individual commit messages for more details.

Download config.guess|sub from
https://git.savannah.gnu.org/gitweb/?p=config.git (at hash
6faca61810d335c7837f320733fe8e15a1431fc2) in order to fix
open-mpi#8410.

A future commit will install these files if they are newer than what
Autoconf installs.

Signed-off-by: Jeff Squyres <[email protected]>
(cherry picked from commit 0ad2e81)
Per open-mpi#8410, have autogen.pl
check each config.sub and config.guess that it finds with a known-good
version of that file if the known-good version has a timestamp version
that is newer than what Autoconf installed.

We also skip updating anything in the 3rd-party tree; we don't really
want to mess with those packages.

Signed-off-by: Jeff Squyres <[email protected]>
(cherry picked from commit 4a002ce)
@jsquyres jsquyres added this to the v4.1.1 milestone Jan 27, 2021
@jsquyres jsquyres requested a review from bwbarrett January 27, 2021 15:27
@jsquyres
Copy link
Member Author

bot:ibm:retest

@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/37be967a7141b92189503be0e2c704cb

@open-mpi open-mpi deleted a comment from ibm-ompi Jan 27, 2021
@jsquyres
Copy link
Member Author

@jjhursey The IBM CI has failed twice, and it kinda looks like a "filesystem full" type of error. But we're only seeing the error in make install, not make all. Can you have a look?

@jjhursey
Copy link
Member

I'm looking. It's an odd failure mode, almost like it was getting files deleted out from under it. The /tmp has hundreds of GB of space free so that shouldn't have been the problem.

@jjhursey
Copy link
Member

bot:ibm:xl:retest

@jjhursey
Copy link
Member

The machine that hosts IBM Ci had a file system (and then network) blip this afternoon, as best as I can tell. It builds OMPI in /tmp (local disk) but installs on a parallel file system (for the scaling run tests). The parallel file system blinked out for a moment in a not great way. So that would explain why 'make all' worked but 'make install' threw the error.

Ci is still running slower than normal, but running. Once the system quiets down I'll re-mount some things to see if that brings us back to normal performance.

@open-mpi open-mpi deleted a comment from ibm-ompi Jan 27, 2021
@jjhursey
Copy link
Member

Let's try one more time 🤞
bot:ibm:xl:retest

@jsquyres jsquyres merged commit 4779d8e into open-mpi:v4.1.x Jan 27, 2021
@jsquyres jsquyres deleted the pr/v4.1.x/autogen-config-dot-wot-updates-for-apple-m1 branch January 27, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants