v3.1.x: Make sure MPIR_Breakpoint() is compiled without CFLAGS. #8432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In optimized builds, CFLAGS contains various optimizations such as -O3, and is propogated by automake to all files. To work-around this, isolate MPIR_Breakpoint() and other MPIR_* symbols into its own library built with debugger specific CFLAGS. To prevent CFLAGS from being polluted elsewhere in the make tree, build this in its own tiny stand-alone makefile. Fixes open-mpi#7757 Signed-off-by: Austen Lauria <[email protected]> (cherry picked from commit 6d82003)
awlauria
changed the title
jjhursey
approved these changes
Feb 1, 2021
|
Per discussion today, we'll merge this into the v3.1.x branch, but we will not be creating a new release for it. A new nightly snapshot tarball should be emitted tonight at https://www.open-mpi.org/nightly/v3.1.x/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In optimized builds, CFLAGS contains various optimizations such as -O3,
and is propogated by automake to all files. To work-around this,
isolate MPIR_Breakpoint() and other MPIR_* symbols into its own library
built with debugger specific CFLAGS.
To prevent CFLAGS from being polluted elsewhere in the make tree, build
this in its own tiny stand-alone makefile.
Fixes #7757
Signed-off-by: Austen Lauria [email protected]
(cherry picked from commit 6d82003)