v4.1.x: Fix case where debuggers cannot read the MPIR proctable. #8571
Conversation
awlauria
changed the title
There was a problem hiding this comment.
The commit message does not explain why the change fixes the problem.
I'm sorry to harp on this, and I realize that the user says that this fixes the issue for them, but I do not understand why moving extern struct foo *bar; from a .h file to a .c file changes anything in the emitted .o file.
I worry that we're not actually fixing the problem, but just somehow changing the symptom of a different / underlying issue.
Clearly, I'm missing something. If the change is correct but the implication of this change is subtle, please explain it in a comment in the code and/or in the commit message. Thanks!
Also, my new git commit checker CI should have failed because the cited cherry-pick commit doesn't exist on anywhere in the repo yet. 😦 I'll investigate that separately.
Make sure the definition of the MPIR_Proctable is in a header file that is included in the file orted_mpir_breakpoint.c, which is compiled with -g and compiled without optimizations. Otherwise, the debugger (such as gdb) won't know the complete definition of the proctable, preventing it from being able to read it. Since the MPIR_proctable should be accessed from orted_submit.c and orted_mpir_breakpoint.c, move it to the mpir_orted.h header file. See issue: open-mpi#8563 Signed-off-by: Austen Lauria <[email protected]> (cherry picked from commit a71fbaf)
awlauria
changed the title
|
Updated the PR. |
Make sure the definition of the MPIR_Proctable
is in a header file that is included in the file
orted_mpir_breakpoint.c, which is compiled with -g
and compiled without optimizations.
Otherwise, the debugger (such as gdb) won't know
the complete definition of the proctable, preventing
it from being able to read it.
Since the MPIR_proctable should be accessed from
orted_submit.c and orted_mpir_breakpoint.c, move it
to the mpir_orted.h header file.
See issue: #8563
Signed-off-by: Austen Lauria [email protected]
(cherry picked from commit a71fbaf)
Fixes #8563