fortran: check for ISO_FORTRAN_ENV:REAL16 #8637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggouaillardet
force-pushed
the
topic/iso_fortran_env_real16
branch
from
2688c7d to
5816fea
Compare
bosilca
approved these changes
Mar 17, 2021
|
@bosilca I pushed an other commit to generate subroutines for both let me know whether I should squash or remove it. |
ggouaillardet
force-pushed
the
topic/iso_fortran_env_real16
branch
from
9d6f7db to
6c5ddec
Compare
bosilca
approved these changes
Mar 17, 2021
ggouaillardet
force-pushed
the
topic/iso_fortran_env_real16
branch
from
6c5ddec to
d0085f6
Compare
Though this has not landed into the Fortran standard, some compilers support REAL16 in the ISO_FORTRAN_ENV module. Use it when available, and fallback to REAL*2 and COMPLEX*4 otherwise. Thanks Jeff Hammond for reporting this issue Ref. open-mpi#8616 Signed-off-by: Gilles Gouaillardet <[email protected]>
|
@kawashima-fj thanks for the thorough review, I made the requested changes. |
ggouaillardet
force-pushed
the
topic/iso_fortran_env_real16
branch
from
d0085f6 to
3a6fc24
Compare
jsquyres
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though this has not landed into the Fortran standard,
some compilers support REAL16 in the ISO_FORTRAN_ENV
module.
Use it when available, and fallback to REAL2
and COMPLEX4 otherwise.
Thanks Jeff Hammond for reporting this issue
Ref. #8616
Signed-off-by: Gilles Gouaillardet [email protected]