[v4.1.x] mtl/ofi: Disable CUDA convertor for specified ofi providers #8821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is only in v4.x as code in v5.x was rewritten to use FI_HMEM and there is no plan to backport the related patches. Refs: 8762 Signed-off-by: Goldman, Adam <[email protected]>
|
Can one of the admins verify this patch? |
|
@rajachan @mwheinz @wckzhang, Can you please review? Also, I am not sure how to go about this as there is no way to really cherry-pick this from master: |
|
You can add |
|
ok to test |
|
@acgoldma Is it worthwhile, once this PR is merged, to cherry-pick to v4.0.x? |
hppritcha
approved these changes
Apr 18, 2021
Yes, I think it is worth while. |
acgoldma
commented
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is only in v4.x as code in v5.x was rewritten to use FI_HMEM
and there is no plan to backport the related patches.
Refs: #8762
Signed-off-by: Goldman, Adam [email protected]
bot:notacherrypick