Fix a bunch of compiler warnings #8882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
reviewed
Apr 29, 2021
bwbarrett
reviewed
Apr 29, 2021
Fair enough; will do. |
mdosanjh
approved these changes
Apr 29, 2021
Fix compiler warnings about having "shadow" variable declarations. Signed-off-by: Jeff Squyres <[email protected]>
According to the latest MPI-4.0 draft (as of May 2021), the "buf" arg to MPI_Precv_init() is not const. Signed-off-by: Jeff Squyres <[email protected]>
Rename to flags_derived, just to be slightly more clear. Signed-off-by: Jeff Squyres <[email protected]>
We don't need to have two variables: one named exec_command and one named exec_cmd. Consolidate down to just a single variable (exec_command), and in doing so, fix a compiler warning that exec_command may not have been initialized (due to confusion between exec_command and exec_cmd). Also remove some #if 0/dead code. Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/fix-warnings
branch
from
7bae21d to
ed26da7
Compare
- Remove dead code - Fix shadow variable declarations - Cast %p arguments to (void*) - Make integer comparisons agree in sign - Make a local function static so that it does not require a prior declaration Signed-off-by: Jeff Squyres <[email protected]>
being deleted because, per discussion between @bosilca and @jsquyres on 29 Apr 2021, @bosilca is pretty sure that this code *should* be being invoked from somewhere -- otherwise, we likely have a leak in MPI_FINALIZE. His team is looking into it. Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/fix-warnings
branch
from
ed26da7 to
d301e68
Compare
bwbarrett
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't make master compiler-warning free, but it does both remove a bunch of warnings and fix a few genuine (minor) bugs.
See individual commit messages for more details.
NOTE: This PR contains changes to 3rd-party/treematch. @bosilca has previously stated that we have effectively forked from the upstream treematch, so I assume that this is ok. If that's wrong, we can roll the tree match change commit out of this PR.