v5.0.x: coll/base: Fix the error handling in couple of collectives. #8934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
|
@zhngaj Please update this commit with the cherry-pick -x similar to the 4.1 branch. |
In the error handling of ompi_coll_base_alltoallv_intra_basic_linear, an ompi request's status could be MPI_SUCCESS, and could be returned, instead of a real error code. Add a check against ompi request's req_status.MPI_ERROR to ensure a real error code is returned. Other collectives (alltoall, barrier, bcast, gather, reduce, scatter) had the similar error handling, so apply the change as well. Signed-off-by: Jie Zhang <[email protected]> (cherry picked from commit a7613cd)
zhngaj
force-pushed
the
v5.0.x-err-handling-fix
branch
from
19bb15d to
10b29c5
Compare
Done. |
awlauria
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the error handling of ompi_coll_base_alltoallv_intra_basic_linear,
an ompi request's status could be MPI_SUCCESS, and could be returned,
instead of a real error code.
Add a check against ompi request's req_status.MPI_ERROR to ensure
a real error code is returned.
Other collectives (alltoall, barrier, bcast, gather, reduce, scatter)
had the similar error handling, so apply the change as well.
Signed-off-by: Jie Zhang [email protected]